search

apache / apisix-go-plugin-runner

Go Plugin Runner for APISIX
https://apisix.apache.org/
Apache License 2.0
167 stars 69 forks source link

refactor: rename Response to ReqResponse #88

Closed soulbird closed 2 years ago

soulbird commented 2 years ago

We will add response.go and Response interface to support response phase

codecov-commenter commented 2 years ago

Codecov Report

Merging #88 (fb1cec7) into master (413b903) will decrease coverage by 1.74%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   81.23%   79.49%   -1.75%     
==========================================
  Files          11       12       +1     
  Lines         746      746              
==========================================
- Hits          606      593      -13     
- Misses        102      114      +12     
- Partials       38       39       +1
Impacted Files Coverage Δ
internal/http/request.go 93.36% <ø> (-0.14%) :arrow_down:
internal/http/header.go 100.00% <100.00%> (ø)
internal/http/req-response.go 100.00% <100.00%> (ø)
internal/plugin/plugin.go 78.68% <100.00%> (ø)
internal/server/server.go 56.91% <0.00%> (-10.57%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 413b903...fb1cec7. Read the comment docs.

spacewander commented 2 years ago

Please make the CI pass, thanks!