help request: How to define keepalive through ApisixUpstream_ The idle of the pool_ Timeout

apache / apisix-ingress-controller

APISIX Ingress Controller for Kubernetes

https://apisix.apache.org/

Apache License 2.0

1.02k stars 343 forks source link

help request: How to define keepalive through ApisixUpstream_ The idle of the pool_ Timeout #1883

Open jinjianming opened 1 year ago

jinjianming commented 1 year ago

Description

apiVersion:  apisix.apache.org/v2
kind: ApisixUpstream
metadata:
  name: nginx
spec:
  loadbalancer:
    type: roundrobin
  keepalive_pool:
    idle_timeout: 90s

Environment

APISIX version (run apisix version):
Operating system (run uname -a):
OpenResty / Nginx version (run openresty -V or nginx -V):
etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
APISIX Dashboard version, if relevant:
Plugin runner version, for issues related to plugin runners:
LuaRocks version, for installation issues (run luarocks --version):

Revolyssup commented 1 year ago

@tao12345666333 Currently ApisixUpstream CR doesn't support this. Should I add the support ?

tao12345666333 commented 1 year ago

According to the schema specification of APISIX Upstream, we can add this field. https://github.com/apache/apisix/blob/f2337f25d4bdbe7291810f36c0fbedd5cea8d29d/apisix/schema_def.lua#L417-L436

If you are willing to add this feature, welcome to submit a PR. @jinjianming

This is an issue that is very suitable for beginners to contribute.

tao12345666333 commented 1 year ago

This is an issue that is very suitable for beginners to contribute.

@Revolyssup as I said above, let's leave this for beginners

AHNakbari commented 1 year ago

can you kindly assign me this issue?

lingsamuel commented 1 year ago

@splenta22 assigned, thanks!

slayer321 commented 3 months ago

Hey @tao12345666333 , I'm not sure If @AHNakbari is still working on this Issue. If not can you Please assign it to me

slayer321 commented 4 weeks ago

Hey @Revolyssup , I'm working on this issue and wanted to understand how do you folks generate the CRD's? I tried using below command

controller-gen crd paths=./pkg/kube/apisix/apis/... output:crd:dir=./samples/deploy/crd/v1

But I was generating the whole different file for me.

Also I cannot find and make command for it though I found update-codegen with generated other things.