search

apache / apisix

The Cloud-Native API Gateway
https://apisix.apache.org/blog/
Apache License 2.0
14.46k stars 2.52k forks source link

bug: Kubernetes discovery determines whether to enable endpointslice #11631

Open MrLinMH opened 2 weeks ago

MrLinMH commented 2 weeks ago

Current Behavior

In the source code, when judging whether to watch endpoint slices, watch_endpoint_slices_schema is used, as follows: image

But what is defined in the schema is watch_endpoint_slices: image

When determining whether to watch endpoint slices, you should use conf.watch_endpoint_slices , watch_endpoint_slices_schema is only a local variable in the lua file apisix/discovery/kubernetes/schema.lua . It will not appear in the configuration item schema of discovery kubernetes. The actual variable used in the schema is watch_endpoint_slices .

Expected Behavior

No response

Error Logs

No response

Steps to Reproduce

PR: https://github.com/apache/apisix/pull/10916/files

Environment

APISIX version: 3.9.0 (master branch also has this problem)

zhoujiexiong commented 2 weeks ago

It looks like the relevant E2E test cases also need further refinement.

@MrLinMH PR to fix the issue?

slayer321 commented 2 weeks ago

Hey @zhoujiexiong , I did like to work on this issue. Can you please assign it to me.