apache / apisix

The Cloud-Native API Gateway
https://apisix.apache.org/blog/
Apache License 2.0
14.5k stars 2.52k forks source link

feat: extend chaitin-waf plugin functionalities #9945

Open lingsamuel opened 1 year ago

lingsamuel commented 1 year ago

There are some todos need to be done in chaitin-waf plugin.

  1. add a configuration for "mode" attribute
  2. add a configuration to enable/disable the real client IP
  3. use lrucache to cache the var expression result (traffic-split plugin also need this)
PalAditya commented 1 year ago

Hi, I'd like to work on this if possible. Adding a few questions as well to make sure my understanding is correct:

sreeram-venkitesh commented 1 week ago

I have opened https://github.com/apache/apisix/pull/11705 to add the cache. @lingsamuel @moonming Please review the PR and let me know if I'm on the right path. I'd love to work on the rest of the tasks in this issue as well once this is done. Maybe I can push it in the same PR. Please let me know!