search

apache / arrow-adbc

Database connectivity API standard and libraries for Apache Arrow
https://arrow.apache.org/adbc/
Apache License 2.0
330 stars 84 forks source link

csharp/src/Drivers/Apache: Rename this project and add NuGet creation #1726

Open CurtHagenlocher opened 2 months ago

CurtHagenlocher commented 2 months ago

What feature or improvement would you like to see?

The name "Apache.Arrow.Adbc.Drivers.Apache" isn't very meaningful. I'd propose "Apache.Arrow.Adbc.Drivers.HiveServer2" as an alternative but am open to other suggestions. The name should be finalized before we publish a NuGet package in order to avoid confusion.

davidhcoe commented 2 months ago

I would actually prefer they each have their own names:

but that would require splitting them to different projects and managing the dependencies accordingly.

CurtHagenlocher commented 2 months ago

Splitting them is probably the right thing to do in a number of respects, but I wouldn't want to duplicate the code and for that we'd still need a single shared dependency.

davidhcoe commented 2 months ago

I also thought about Apache.Arrow.Adbc.Drivers.Thrift since things all build on that, but that seemed less helpful

birschick-bq commented 2 months ago

I think in the long term we don't want a shared artifact/nuget package for both drivers. It might limit the flexibility of release for each driver. So I'd vote for separate projects/artifacts for the two drivers. So a shared dependency on the Hive common code.

Once we get to working on Impala, we will probably discover more common code to share in the shared project.

Any, I agree with David's three names/projects: