search

apache / arrow-adbc

Database connectivity API standard and libraries for Apache Arrow
https://arrow.apache.org/adbc/
Apache License 2.0
360 stars 86 forks source link

ci: adbc-driver-snowflake-test fails on SnowflakeConnectionTest.MetadataGetObjectsColumns #1788

Closed raulcd closed 4 months ago

raulcd commented 4 months ago

What happened?

On several PRs the Snowflake Integration Tests job seems to fail:

The error is:

 /home/runner/work/arrow-adbc/arrow-adbc/c/validation/adbc_validation_connection.cc:824: Failure
Value of: found_expected_table
  Actual: true
Expected: false
Google Test trace:
/home/runner/work/arrow-adbc/arrow-adbc/c/validation/adbc_validation_connection.cc:758: Filter: (no filter)

[  FAILED  ] SnowflakeConnectionTest.MetadataGetObjectsColumns

How can we reproduce the bug?

No response

Environment/Setup

No response

lidavidm commented 4 months ago

@zeroshade any idea?

zeroshade commented 4 months ago

at some point between our toying with the all of the casing and quotes, we ended up with two tables in the ADBC_TESTING db: bulk_ingest and BULK_INGEST. Since we do our comparison as a case-insensitive comparison, we ended up finding the table twice and failing.

I've removed the duplicate table from our snowflake instance and the test succeeds locally, so it should succeed on here too.

zeroshade commented 4 months ago

And there we go. I re-ran the job and we have success:

image

lidavidm commented 4 months ago

Thanks!