apache / arrow-adbc

Database connectivity API standard and libraries for Apache Arrow
https://arrow.apache.org/adbc/
Apache License 2.0
357 stars 86 forks source link

csharp: standardize on formatting conventions #1844

Open CurtHagenlocher opened 4 months ago

CurtHagenlocher commented 4 months ago

What feature or improvement would you like to see?

There's a mix of "_field" and "this.field" in the code in addition to other formatting inconsistencies. It would be good to standardize.

KazimMir commented 2 months ago

Is there any preference with one over the other?

CurtHagenlocher commented 1 month ago

My only strong personal preference is for consistency inside a single codebase, but alignment with the Arrow C# code probably isn't a bad thing and that uses mostly "_field".