feat(csharp/src/Drivers): introduce Interop.FlightSql driver

apache / arrow-adbc

Database connectivity API standard and libraries for Apache Arrow

https://arrow.apache.org/adbc/

Apache License 2.0

384 stars 97 forks source link

feat(csharp/src/Drivers): introduce Interop.FlightSql driver #2214

Open davidhcoe opened 1 month ago

davidhcoe commented 1 month ago

Introduces the Interop.FlightSql driver to use the FlightSQL Go driver from C#
Adds support for testing against multiple FlightSQL environments simultaneously in the configuration (something we may want to carry forward to other projects)
Has a first set of test sample data specific to DuckDB and SQLite using https://github.com/voltrondata/SQLFlite as the server(s).
Adds support for the IntervalType in a generic capacity

davidhcoe commented 1 month ago

Is there any way to make the process of creating something to load the driver and wrap it more generic so that potential future drivers don't require as much boiler plate as this appears to?

Otherwise, this looks pretty fine to me but I'm not very experienced with C#

Like a base class that https://github.com/apache/arrow-adbc/blob/7fc08cce7404b000c400e00f208ded6dc80f6bb8/csharp/src/Drivers/Interop/FlightSql/FlightSqlDriverLoader.cs could implement?

lidavidm commented 1 month ago

I do agree there's some boilerplate that might be good to factor out eventually, if we're going to have multiple packages like this

zeroshade commented 1 month ago

Like a base class that https://github.com/apache/arrow-adbc/blob/7fc08cce7404b000c400e00f208ded6dc80f6bb8/csharp/src/Drivers/Interop/FlightSql/FlightSqlDriverLoader.cs could implement?

Exactly