search

apache / arrow-adbc

Database connectivity API standard and libraries for Apache Arrow
https://arrow.apache.org/adbc/
Apache License 2.0
385 stars 97 forks source link

java: assembly:single failed in RC verification #2314

Closed kou closed 1 week ago

kou commented 1 week ago

What happened?

Java's source verification failed with the following error:

```console $ TEST_DEFAULT=0 TEST_SOURCE=1 dev/release/verify-release-candidate.sh 15 1 + mvn -B clean install assembly:single source:jar javadoc:jar -Papache-release -DdescriptorId=source-release -T 2C -DskipTests -Dgpg.skip [INFO] Scanning for projects... [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/arrow/arrow-bom/18.0.0/arrow-bom-18.0.0.pom [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/arrow/arrow-bom/18.0.0/arrow-bom-18.0.0.pom (10.0 kB at 17 kB/s) [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.11.3/junit-bom-5.11.3.pom [INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.11.3/junit-bom-5.11.3.pom (5.6 kB at 202 kB/s) [INFO] ------------------------------------------------------------------------ [INFO] Reactor Build Order: [INFO] [INFO] Apache Arrow ADBC Java Root POM [pom] [INFO] Arrow ADBC Core [jar] [INFO] Arrow ADBC Driver Manager [jar] [INFO] Arrow ADBC SQL [jar] [INFO] Arrow ADBC Driver Flight SQL [jar] [INFO] Arrow ADBC Driver Validation Suite [jar] [INFO] Arrow ADBC Driver Flight SQL Validation [jar] [INFO] Arrow ADBC Driver JDBC [jar] [INFO] Arrow ADBC Driver JDBC Validation with Derby [jar] [INFO] Arrow ADBC Driver JDBC Validation with Microsoft SQL Server [jar] [INFO] Arrow ADBC Driver JDBC Validation with PostgreSQL [jar] [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-remote-resources-plugin/3.2.0/maven-remote-resources-plugin-3.2.0.pom (...downloading logs...) [INFO] [INFO] Using the MultiThreadedBuilder implementation with a thread count of 48 [INFO] [INFO] -------------< org.apache.arrow.adbc:arrow-adbc-java-root >------------- [INFO] Building Apache Arrow ADBC Java Root POM 0.15.0 [1/11] [INFO] --------------------------------[ pom ]--------------------------------- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-gpg-plugin/3.2.4/maven-gpg-plugin-3.2.4.pom (...downloading logs...) [INFO] [INFO] --- maven-clean-plugin:3.4.0:clean (default-clean) @ arrow-adbc-java-root --- [INFO] [INFO] --- maven-enforcer-plugin:3.5.0:enforce (enforce-maven-version) @ arrow-adbc-java-root --- (...downloading logs...) [INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed [INFO] [INFO] --- maven-enforcer-plugin:3.5.0:enforce (enforce-java-version) @ arrow-adbc-java-root --- [INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed [INFO] [INFO] --- apache-rat-plugin:0.16.1:check (rat-checks) @ arrow-adbc-java-root --- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/rat/apache-rat-core/0.16.1/apache-rat-core-0.16.1.pom (...downloading logs...) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 109 licenses. [INFO] [INFO] --- maven-remote-resources-plugin:3.2.0:process (process-resource-bundles) @ arrow-adbc-java-root --- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-archiver/3.6.1/maven-archiver-3.6.1.pom (...downloading logs...) [INFO] Copying 3 resources from 1 bundle. [INFO] [INFO] --- maven-assembly-plugin:3.7.1:single (source-release-assembly) @ arrow-adbc-java-root --- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/resources/apache-source-release-assembly-descriptor/1.5/apache-source-release-assembly-descriptor-1.5.pom (...downloading logs...) [INFO] Building zip: /data/arrow/adbc-verify-rc/arrow-adbc-15.8lyA5/apache-arrow-adbc-15/java/target/arrow-adbc-java-root-0.15.0-source-release.zip [INFO] [INFO] --- maven-source-plugin:3.3.1:jar-no-fork (attach-sources) @ arrow-adbc-java-root --- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-archiver/4.9.1/plexus-archiver-4.9.1.pom (...downloading logs...) [INFO] [INFO] --- maven-javadoc-plugin:3.11.1:jar (attach-javadocs) @ arrow-adbc-java-root --- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-sink-api/2.0.0/doxia-sink-api-2.0.0.pom (...downloading logs...) [INFO] Not executing Javadoc as the project is not a Java classpath-capable package [INFO] [INFO] --- checksum-maven-plugin:1.11:artifacts (source-release-checksum) @ arrow-adbc-java-root --- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/bouncycastle/bcprov-jdk15on/1.69/bcprov-jdk15on-1.69.pom (...downloading logs...) [INFO] arrow-adbc-java-root-0.15.0-source-release.zip - SHA-512 : 49952803921eac3f510c414f0786cefb9e4f671b12096c65cf4a202ad7fd2caeff0a40a27038d35733091ac16f1475b4034e88eec2ae26b7dbb53c6cacbbfc60 [INFO] [INFO] --- maven-gpg-plugin:3.2.4:sign (sign-release-artifacts) @ arrow-adbc-java-root --- [INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/resolver/maven-resolver-util/1.9.18/maven-resolver-util-1.9.18.pom (...downloading logs...) [INFO] [INFO] --- maven-install-plugin:3.1.2:install (default-install) @ arrow-adbc-java-root --- [INFO] Installing /data/arrow/adbc-verify-rc/arrow-adbc-15.8lyA5/apache-arrow-adbc-15/java/pom.xml to /home/kou/.m2/repository/org/apache/arrow/adbc/arrow-adbc-java-root/0.15.0/arrow-adbc-java-root-0.15.0.pom [INFO] Installing /data/arrow/adbc-verify-rc/arrow-adbc-15.8lyA5/apache-arrow-adbc-15/java/target/arrow-adbc-java-root-0.15.0-source-release.zip to /home/kou/.m2/repository/org/apache/arrow/adbc/arrow-adbc-java-root/0.15.0/arrow-adbc-java-root-0.15.0-source-release.zip [INFO] Installing /data/arrow/adbc-verify-rc/arrow-adbc-15.8lyA5/apache-arrow-adbc-15/java/target/arrow-adbc-java-root-0.15.0-source-release.zip.sha512 to /home/kou/.m2/repository/org/apache/arrow/adbc/arrow-adbc-java-root/0.15.0/arrow-adbc-java-root-0.15.0-source-release.zip.sha512 [INFO] [INFO] --- maven-assembly-plugin:3.7.1:single (default-cli) @ arrow-adbc-java-root --- [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Arrow ADBC Java Root POM 0.15.0: [INFO] [INFO] Apache Arrow ADBC Java Root POM .................... FAILURE [ 17.105 s] [INFO] Arrow ADBC Core .................................... SKIPPED [INFO] Arrow ADBC Driver Manager .......................... SKIPPED [INFO] Arrow ADBC SQL ..................................... SKIPPED [INFO] Arrow ADBC Driver Flight SQL ....................... SKIPPED [INFO] Arrow ADBC Driver Validation Suite ................. SKIPPED [INFO] Arrow ADBC Driver Flight SQL Validation ............ SKIPPED [INFO] Arrow ADBC Driver JDBC ............................. SKIPPED [INFO] Arrow ADBC Driver JDBC Validation with Derby ....... SKIPPED [INFO] Arrow ADBC Driver JDBC Validation with Microsoft SQL Server SKIPPED [INFO] Arrow ADBC Driver JDBC Validation with PostgreSQL .. SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18.542 s (Wall Clock) [INFO] Finished at: 2024-11-09T02:25:29Z [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.7.1:single (default-cli) on project arrow-adbc-java-root: Error reading assemblies: No assembly descriptors found. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException ```

This may be caused by my environment but I don't know how to debug this because I'm not familiar with Java...

FYI: I didn't see this error with old ADBC releases.

Stack Trace

No response

How can we reproduce the bug?

No response

Environment/Setup

OS: Debian GNU/Linux sid

Maven:

$  mvn --version
Apache Maven 3.8.7
Maven home: /usr/share/maven
Java version: 17.0.12-ea, vendor: Debian, runtime: /usr/lib/jvm/java-17-openjdk-amd64
Default locale: ja_JP, platform encoding: UTF-8
OS name: "linux", version: "6.9.8-amd64", arch: "amd64", family: "unix"
lidavidm commented 1 week ago

Hmm, @laurentgo did recently upgrade the parent POM version, but the verification worked in CI...let me see if this happens for me

lidavidm commented 1 week ago

I wasn't able to replicate with Conda maven (3.9.9). I'll try again in a bit with your version of maven

lidavidm commented 1 week ago

I wasn't able to verify with 3.8.7 either, though my Java version is also different:

Apache Maven 3.8.7
Maven home: /usr/share/maven
Java version: 21.0.3, vendor: Eclipse Adoptium, runtime: /usr/lib/jvm/temurin-21-jdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.1.0-21-amd64", arch: "amd64", family: "unix"
lidavidm commented 1 week ago

Oh. Are you using the latest release script?

I have:

+ mvn -B clean install -Papache-release -T 2C -DskipTests -Dgpg.skip

You have:

+ mvn -B clean install assembly:single source:jar javadoc:jar -Papache-release -DdescriptorId=source-release -T 2C -DskipTests -Dgpg.skip
kou commented 1 week ago

Ah, yes. I'm using the verification script in main. I'll try the verification script on the tag.

lidavidm commented 1 week ago

Hmm, you might just need to pull main? assembly:single step was removed in 12a74afdbad3ecb39cb12f6dee808aef9fdbd36a

kou commented 1 week ago

Oh, sorry. I missed the change. I'll update.

kou commented 1 week ago

I could solve this by updating to the latest main. Thanks!