search

apache / arrow-adbc

Database connectivity API standard and libraries for Apache Arrow
https://arrow.apache.org/adbc/
Apache License 2.0
385 stars 98 forks source link

Java verification requires local checkout to have submodules initialized #2321

Closed paleolimbot closed 1 week ago

paleolimbot commented 1 week ago

What happened?

I was tripped up verifying ADBC Libraries 15 because Java tests point to the checkout of the testing submodule. It doesn't seem like this tripped anybody else up but I imagine the verification script should either clone its own version of the checkout or make sure it exists for the person doing the verifying (I can take a look at this).

Stack Trace

I lost the terminal with this error but will try to recreate later...it's something about a certificates .pem file in the FlightSQL tests.

How can we reproduce the bug?

No response

Environment/Setup

No response

lidavidm commented 1 week ago

Hmm. The source archive includes the testing files already. (The packaging step explicitly fetches submodules: https://github.com/apache/arrow-adbc/blob/main/.github/workflows/packaging.yml#L68)

lidavidm commented 1 week ago

Also, I am verifying ADBC from a checkout without submodules set up so it doesn't seem like that should be the issue...possibly I have something else in my environment though

paleolimbot commented 1 week ago

The error I get is:

# USE_CONDA=1 TEST_DEFAULT=0 TEST_JAVA=1 ./verify-release-candidate.sh
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   MutualTlsTest » FileNotFound /Users/deweydunnington/Desktop/rscratch/arrow-adbc/java/driver/flight-sql/../../../testing/data/flight/cert0.pem (No such file or directory)
[ERROR]   TlsTest » FileNotFound /Users/deweydunnington/Desktop/rscratch/arrow-adbc/java/driver/flight-sql/../../../testing/data/flight/cert0.pem (No such file or directory)
[INFO] 
[ERROR] Tests run: 16, Failures: 0, Errors: 2, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Arrow ADBC Java Root POM 0.15.0-SNAPSHOT:
[INFO] 
[INFO] Apache Arrow ADBC Java Root POM .................... SUCCESS [  1.088 s]
[INFO] Arrow ADBC Core .................................... SUCCESS [  0.403 s]
[INFO] Arrow ADBC Driver Manager .......................... SUCCESS [  0.799 s]
[INFO] Arrow ADBC SQL ..................................... SUCCESS [  0.101 s]
[INFO] Arrow ADBC Driver Flight SQL ....................... FAILURE [  1.708 s]
[INFO] Arrow ADBC Driver Validation Suite ................. SKIPPED
[INFO] Arrow ADBC Driver Flight SQL Validation ............ SKIPPED
[INFO] Arrow ADBC Driver JDBC ............................. SKIPPED
[INFO] Arrow ADBC Driver JDBC Validation with Derby ....... SKIPPED
[INFO] Arrow ADBC Driver JDBC Validation with Microsoft SQL Server SKIPPED
[INFO] Arrow ADBC Driver JDBC Validation with PostgreSQL .. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.196 s
[INFO] Finished at: 2024-11-14T10:49:57-06:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on project adbc-driver-flight-sql: 
[ERROR] 
[ERROR] See /Users/deweydunnington/Desktop/rscratch/arrow-adbc/java/driver/flight-sql/target/surefire-reports for the individual test results.
[ERROR] See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :adbc-driver-flight-sql
paleolimbot commented 1 week ago

I suppose that's on a local checkout and not explicitly on a packaged tarball (where I do see the appropriate files). It's theoretically possible that I forgot to type 15 1 at the end when I was verifying, but I got this on two machines.

lidavidm commented 1 week ago

I am verifying from a local checkout as well - does the 15 1 work for you? (Ah, I guess the files are gone now...)

paleolimbot commented 1 week ago

I'll revisit next release!