Open lidavidm opened 1 year ago
Also because
Building Go Static lib adbc_driver_flightsql
# runtime/cgo
Microsoft (R) C/C++ Optimizing Compiler Version 19.35.32217.1 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl : Command line error D8021: invalid numeric argument '/Werror' [C:\Users\User\arrow-adbc\build\driver\flig
htsql\adbc_driver_flightsql_static_target.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets
(247,5): error MSB8066: Custom build for 'C:\Users\User\arrow-adbc\build\CMakeFiles\7756ba06561194be52670233c
766fa3d\adbc_driver_flightsql.lib.rule;C:\Users\User\arrow-adbc\build\CMakeFiles\45e89061b0894b49826f891e2ae3
8eeb\adbc_driver_flightsql_static_target.rule' exited with code 2. [C:\Users\User\arrow-adbc\build\driver\fli
ghtsql\adbc_driver_flightsql_static_target.vcxproj]
So first we need the conda package m2w64-gcc to get gcc/g++ available, and we have to force go to use it (over msvc which we want to use for everything else). But then tests don't link because we build a DLL, but the Visual Studio build system expects to link with a .obj
file.
I don't see how to create an importlib, either; I wonder if what we're doing is even possible on Windows.
I think we'll have to punt on this until there's demand.
Hmm, if we set CC and CXX for the Go command only...and it appears a .lib does get built...