apache / arrow-adbc

Database connectivity API standard and libraries for Apache Arrow
https://arrow.apache.org/adbc/
Apache License 2.0
355 stars 86 forks source link

Improve Windows PowerShell verification #682

Open paleolimbot opened 1 year ago

paleolimbot commented 1 year ago

From the instructions side, it might be nice to add a section to the verification instructions. To get it to run at all I had to:

There's one spot where it pauses to ask about installing stuff into a conda environment:

Removing specs: ['gtest']
Transaction

  Prefix: C:\Users\dewey\AppData\Local\Temp\tmp15A0.tmp\conda-env

Then fails with:

C:\Users\dewey\Documents\rscratch\arrow-adbc>exit /B 0
Join-Path : A positional parameter cannot be found that accepts argument 'go'.
At C:\Users\dewey\Documents\rscratch\arrow-adbc\dev\release\verify-release-candidate.ps1:127 char:17
+ $env:GOROOT = $(Join-Path $ArrowTempDir conda-env go)
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Join-Path], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.JoinPathCommand

I don't have time to debug this today but don't mind taking a look before the next release 🙂

lidavidm commented 1 year ago

Hmm, weird. Thought Join-Path was variadic: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.management/join-path?view=powershell-7.3#example-7-combine-an-indefinite-number-of-paths

But I don't see this in 5.1, which I believe is the version shipped with Windows (until W11 possibly?): https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.management/join-path?view=powershell-5.1

lidavidm commented 1 year ago

And GHA includes 7.1, I believe. (The developer VM I use also has 7.1, I'm fairly sure.) So that might explain why.

paleolimbot commented 1 year ago

I shut off that computer for the weekend, but it's whatever gets installed with out-of-the-box Windows 11 Pro as of a few days ago. Either way I have a sane Windows environment now and I'm happy to debug + document (I have to add the R stuff in there anyway).