search

apache / arrow-cookbook

Apache Arrow Cookbook
https://arrow.apache.org/
Apache License 2.0
96 stars 46 forks source link

[C++] Improve C++ Cookbook #261

Closed js8544 closed 1 year ago

js8544 commented 2 years ago

ARROW-17851 Add ARROW_ASSIGN_OR_RAISE to utility macros. Use auto when it improves readability. Adopt C++ 14/17's idioms. Add Visitor classes to visitor pattern.

js8544 commented 2 years ago

I think the other issue is technically we aren't switching to C++17 until Arrow 10 so we may not want to update the cookbook with that until release

Oh right. I'll put this PR on hold for now.

lidavidm commented 1 year ago

This should now be OK if rebased

js8544 commented 1 year ago

This should now be OK if rebased

Thanks! I'll work on this sometime next week.