search

apache / arrow-flight-sql-postgresql

Apache Arrow Flight SQL adapter for PostgreSQL
https://arrow.apache.org/flight-sql-postgresql/
Apache License 2.0
64 stars 9 forks source link

`--output-document` of `wget` seems missed in install doc #145

Closed tikkss closed 9 months ago

tikkss commented 9 months ago

Looks like the --output-document of wget seems missed in Install source documentation. wget saved as closer.lua?action=download&filename=arrow%2Fapache-arrow-flight-sql-postgresql-0.1.0%2Fapache-arrow-flight-sql-postgresql-0.1.0.tar.gz without --output-document. Unable to extract because the file name is different.

https://github.com/apache/arrow-flight-sql-postgresql/blob/d2ee5170ebbd9f0e664c02c9464d3ab2e98a573b/doc/source/install.md?plain=1#L80-L81

Maybe, add to --output-document (-O) will fix it.

-wget "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/apache-arrow-flight-sql-postgresql-${version}/apache-arrow-flight-sql-postgresql-${version}.tar.gz"
+wget "https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/apache-arrow-flight-sql-postgresql-${version}/apache-arrow-flight-sql-postgresql-${version}.tar.gz" -O apache-arrow-flight-sql-postgresql-${version}.tar.gz
kou commented 9 months ago

Ah, you're right. Could you open a PR for this?

kou commented 9 months ago

Could you use --output-file=apache-... instead of -O arrow-...? I want to use long option style as much as possible because it's more self descriptive.

tikkss commented 9 months ago

Sure!

Thanks for your polite explanation. I would like to use long option style.