Open fwojciec opened 3 weeks ago
Hey @fwojciec I'd love to get this cast in. Here's a quick overview of what would be necessary to do so, I'll happily review any PR you make:
addFn
are for adding casts based on the source type and associating compute kernels for casting to them.addToBinaryKernels
to add the appropriate casting kernels for String/LargeString/Binary/LargeBinary by using generics. 3. You'll need to create a new function for casting to StringView/BinaryView since they don't have "Large" variants like String and Binary (for example, notice that there are separate Cast*Fsb*
functions for handling Fixed Size Binary types). You could then add it to the kernels appended by addToBinaryKernels
in the same way as we do for fixed-size-binary. If you run into any issues or difficulties, feel free to put up a draft PR and ping me and I'll help out!
Thanks again for looking into this!
Thank you @zeroshade - that's super helpful! I'll try to have a PR in the next few days.
Describe the bug, including details regarding any error messages, version, and platform.
Casting between string <-> string_view types has been added in C++ and Python implementations of arrow in v18: https://github.com/apache/arrow/pull/43302
I tested this in Python and it works with the latest (18.0.0) pyarrow release:
It doesn't work with the v18 release of arrow-go:
I'd be happy to work on the PR to add it if someone can give me a pointer with description of what would it take - high-level - to add support for this in Go.
Component(s)
Release