search

apache / arrow-go

Official Go implementation of Apache Arrow
https://arrow.apache.org/
Apache License 2.0
34 stars 6 forks source link

GH-11: Add test CI: macOS #86

Closed kou closed 2 months ago

kou commented 2 months ago

Fix GH-11

This part: https://github.com/apache/arrow/blob/58415d1fac50cb829b3dcf08526033d6db8c30db/.github/workflows/go.yml#L305-L360

This also imports ci/scripts/go_{build,test}.sh from apache/arrow.

This also introduce ShellCheck and shfmt with pre-commit.

This also adds apache/arrow-testing and apache/parquet-testing submodules.

kou commented 2 months ago

CI result: https://github.com/kou/arrow-go/actions/runs/10716893068

zeroshade commented 2 months ago

Before we can truly claim that the CI is working, we need to update the package path of the go.mod file and all of the imports in the files to point to itself here instead of the old paths.

We can probably leverage the same sed scripts we use for updating the major version in the imports to quickly update all of the files to use the new import path

kou commented 2 months ago

OK. How about #88?

kou commented 2 months ago

Passed: https://github.com/kou/arrow-go/actions/runs/10745815085

I'll merge this.