search

apache / arrow-java

Official Java implementation of Apache Arrow
https://arrow.apache.org/
Apache License 2.0
4 stars 5 forks source link

Disable Maven RAT check in favor of pre-commit one #436

Open lidavidm opened 1 day ago

lidavidm commented 1 day ago

Describe the enhancement requested

We have two separate RAT checks now, one run during the build and one done via pre-commit. IMO, we should only use the pre-commit one. The build-time RAT check doesn't share config and it is annoying to have the build interrupted during development.

kou commented 1 day ago

Oh, sorry. I missed this.

lidavidm commented 1 day ago

Nah, I forgot about this check too until I ran into it today :grimacing:

For somewhat similar reasons I'm not sure if we'd want to keep Spotless (in Maven) or run google-java-format via pre-commit

kou commented 1 day ago

Ah, Spotless isn't a formatter. (I thought that it's a Java formatter.) We may want to unify all formatters/linters/... to pre-commit.