search

apache / arrow-julia

Official Julia implementation of Apache Arrow
https://arrow.apache.org/julia/
Other
284 stars 59 forks source link

Incorrect syntax in ArrowTypes code #453

Closed ericphanson closed 1 year ago

ericphanson commented 1 year ago

https://github.com/apache/arrow-julia/blob/8aed96998ace1010580a74d03222770140acd579/src/ArrowTypes/src/ArrowTypes.jl#L122-L123

I think this should be

 arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata(T)
 arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata(T)
Moelf commented 1 year ago

We need CI coverage I guess

baumgold commented 1 year ago

@ericphanson - good catch. #453 for the fix. Apologies for the inconvenience.