search

apache / arrow-julia

Official Julia implementation of Apache Arrow
https://arrow.apache.org/julia/
Other
283 stars 60 forks source link

migrate ArrowTypes code that depends on Sockets and UUIDs to extensions #500

Open baumgold opened 4 months ago

baumgold commented 4 months ago

Also add support for Sockets.InetAddr

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ac199b0) 87.34% compared to head (57eb717) 87.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #500 +/- ## ========================================== - Coverage 87.34% 87.24% -0.11% ========================================== Files 26 28 +2 Lines 3288 3276 -12 ========================================== - Hits 2872 2858 -14 - Misses 416 418 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericphanson commented 4 months ago

What happens if a table was serialized with one of these objects, but now you're loading it in a session in which e.g. UUIDs isn't loaded? I think this is probably breaking, unfortunately, since before you'd get back UUID types, whereas now you have to change your code to load UUIDs to get it.

baumgold commented 4 months ago

What happens if a table was serialized with one of these objects, but now you're loading it in a session in which e.g. UUIDs isn't loaded? I think this is probably breaking, unfortunately, since before you'd get back UUID types, whereas now you have to change your code to load UUIDs to get it.

That's a valid point, thanks for bringing it up. Do you think it's worth continuing with this change but bump major rather than minor? Or should we abandon this change for now?

ericphanson commented 4 months ago

These are pretty light packages, and are in the sysimage anyway until v1.11, so to me it doesn’t feel worth all the compat bumps it will cause. I think it’s worth waiting until there’s other reasons for a breaking change, or some big reason why having them is causing problems.

baumgold commented 4 months ago

Sounds good. I'll put this PR on hold for now. Thanks for the feedback.