search

apache / arrow-nanoarrow

Helpers for Arrow C Data & Arrow C Stream interfaces
https://arrow.apache.org/nanoarrow
Apache License 2.0
169 stars 35 forks source link

Export CMake config #352

Closed aljazerzen closed 6 months ago

aljazerzen commented 9 months ago

Closes #350

You probably want the .in file somewhere else.

paleolimbot commented 9 months ago

Thanks for opening this PR!

I looks like there are a few details that need cleaning up...I'm happy to clean up some of the details after we release 0.4.0 (in the next few weeks), or feel free to plug away against the CI on your own if you feel so inclined (and feel free to give me an explicit ping if you run into a problem). Basically, you've exposed a problem that we definitely need to fix (document + test all the ways we support nanoarrow being used in other projects, from CMake or otherwise).

vyasr commented 6 months ago

@aljazerzen are you still interested in finishing up this PR? If not, I'm happy to address your original issue in a new PR. I'm planning to work on a number of related fixes soon to address #400 anyway.

aljazerzen commented 6 months ago

Ummm, I'm not proficient in CMake and have also forgot what I've done here. Go ahead and close this.

vyasr commented 6 months ago

@paleolimbot feel free to close this. I'll have a PR up soon to supersede this one and close the associated issue.

vyasr commented 6 months ago

The new PR is #406