search

apache / arrow-nanoarrow

Helpers for Arrow C Data & Arrow C Stream interfaces
https://arrow.apache.org/nanoarrow
Apache License 2.0
169 stars 35 forks source link

chore: Add basic benchmark setup #384

Closed paleolimbot closed 7 months ago

codecov-commenter commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a41fb2b) 87.89% compared to head (8d7fd28) 87.89%. Report is 1 commits behind head on main.

Files Patch % Lines
r/R/buffer.R 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #384 +/- ## ======================================= Coverage 87.89% 87.89% ======================================= Files 76 76 Lines 13371 13371 ======================================= Hits 11752 11752 Misses 1619 1619 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paleolimbot commented 7 months ago

Do you not want to use find_package to avoid system libraries for some reason (e.g. specific versions or something)?

No specific reason, but it also doesn't cause any issues! In general it's pretty nice that you can clone/build without a package manager (e.g., no conda or brew installs) except for Arrow C++ (and I'd like to remove that when possible).