search

apache / arrow-nanoarrow

Helpers for Arrow C Data & Arrow C Stream interfaces
https://arrow.apache.org/nanoarrow
Apache License 2.0
169 stars 35 forks source link

refactor(r): Refactor how arrays are shallow copied #385

Closed paleolimbot closed 7 months ago

paleolimbot commented 7 months ago

WIP...I think the C half of this is fine, but it seems to have exposed an inconsistency of how I was handling stuff in the R bindings that was long overdue for some simplification.

paleolimbot commented 7 months ago

Closing since #387 fixes the underlying issue (ArrowBufferMove() should not call ArrowBufferReset()). Simplifying how arrays are modified (e.g., to use the R protection mechanism less) is also a good idea; however, not strictly necessary right now.