Open paleolimbot opened 7 months ago
Attention: Patch coverage is 35.44474%
with 479 lines
in your changes are missing coverage. Please review.
Project coverage is 86.09%. Comparing base (
c7a1236
) to head (2afc7b8
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The initial version of converting ArrowArray (or stream of them) to R is implemented in C and is difficult to understand. Not only is this difficult because of the verbose C, the dispatch portion is implemented almost completely twice (once for a single array, once for an array stream). It is at a point currently where it is difficult for me, let alone an external contributor, to add features or fix bugs. Time to refactor!
This approach uses C++ classes/virtual method dispatch to handle the different types of vector conversions. This is similar to how the arrow R package does this except the Arrow R package uses the Arrow C++ converter infrastructure/heavy templating to do dispatch. Here we use a
switch()
and eat the per-batch and per-column virtual method call.Work in progress!