apache / arrow-nanoarrow

Helpers for Arrow C Data & Arrow C Stream interfaces
https://arrow.apache.org/nanoarrow
Apache License 2.0
169 stars 35 forks source link

chore: Fix errors and compiler warnings on verification platforms #420

Closed paleolimbot closed 5 months ago

paleolimbot commented 5 months ago

The latest verification run has a few outstanding errors ( https://github.com/apache/arrow-nanoarrow/actions/runs/8584808770/job/23525503382 ):

This also fixes a mountain of compiler warnings because of -Wmisleading-indentation on gcc that result from the flatcc generated header. These warnings made it difficult to find the Python test message error.

There were also a few other compiler warnings that I noticed when compiling the tests with Meson. Meson compiles tests with -Wall and I don't think CMake compiles them with anything in particular (we do compile the C libraries with many warning flags).