Consolidated IPC extension into main project

apache / arrow-nanoarrow

Helpers for Arrow C Data & Arrow C Stream interfaces

https://arrow.apache.org/nanoarrow

Apache License 2.0

149 stars 34 forks source link

Consolidated IPC extension into main project #511

Closed WillAyd closed 3 weeks ago

paleolimbot commented 3 weeks ago

Taking this on is heroic! All of the hard things here are probably because I designed it badly when I first wrote the IPC extension 😬 .

Just a note that some of these CI jobs you can run locally, too, in case you didn't know:

docker compose run --rm docs
docker compose run --rm coverage
export NANOARROW_PLATFORM=ubuntu && docker compose run --rm verify

I started moving the bundling out of CMake here https://github.com/apache/arrow-nanoarrow/pull/508 and should finish that this week (which may help here if bundling is causing problems, which it usually does 🙂 )

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.61%. Comparing base (8894ebf) to head (1a934d5). Report is 14 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #511 +/- ## ========================================== - Coverage 89.21% 88.61% -0.60% ========================================== Files 90 90 Lines 16294 16554 +260 ========================================== + Hits 14536 14669 +133 - Misses 1758 1885 +127 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WillAyd commented 3 weeks ago

I don't believe the two test failures are related to this change - seems like they showed up in the weekly verification run

https://github.com/apache/arrow-nanoarrow/actions/runs/9432588619

WillAyd commented 3 weeks ago

Still think the windows CI failure might be unrelated - I don't see that as having run in #514