[Bug] sort_boolean function unstable

apache / arrow-rs

Official Rust implementation of Apache Arrow

https://arrow.apache.org/

Apache License 2.0

2.46k stars 727 forks source link

[Bug] sort_boolean function unstable #5447

Open JasonLi-cn opened 6 months ago

JasonLi-cn commented 6 months ago

Describe the bug

UTest

https://github.com/apache/arrow-rs/blob/877e870ee0ade1bece5fc4bec1e62e78889f577c/arrow-ord/src/sort.rs#L1481-L1490

Rustc

nightly-2023-05-15-aarch64-apple-darwin: :x:

thread 'sort::tests::test_sort_boolean' panicked at 'assertion failed: `(left == right)`
  left: `PrimitiveArray<UInt32>
[
  0,
  5,
  3,
]`,
 right: `PrimitiveArray<UInt32>
[
  0,
  5,
  2,
]`',

1.71.1-aarch64-apple-darwin: :white_check_mark:

To Reproduce

Expected behavior

Additional context

tustvold commented 6 months ago

Sorts are unstable as documented

Duplicate of https://github.com/apache/arrow-rs/issues/4545

JasonLi-cn commented 6 months ago

Sorts are unstable as documented

Duplicate of #4545

In order to pass the cargo test, is the solution to modify this test case?