Switch From Snafu to thiserror

tustvold commented 1 month ago

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently snafu is part of the public API of object_store. This is unfortunate as it is a pre-1.0 crate and is making breaking releases. We also make relatively limited use of its functionality, with quite a lot of use of context(false).

Describe the solution you'd like

I'd like to propose switching to using thiserror, as I think this would have some advantages:

It is a 1.0.0 release
It doesn't expose anything beyond implementing the Error trait
It has broader ecosystem adoption than Snafu
It has a potentially less steep learning curve

Describe alternatives you've considered

We could not do this.

Additional context

alamb commented 1 month ago

this seems fine to me

crepererum commented 3 weeks ago

It has broader ecosystem adoption than Snafu

By approximately 10x.

This is snafu:

And this is thiserror:

alamb commented 3 weeks ago

Now we just need someone who wants to do the work

Xuanwo commented 3 weeks ago

I'm willing to take this. I have some ideas about the error design, maybe it's a great time to do it too?

apache / arrow-rs

Switch From Snafu to thiserror #6166