search

apache / arrow-rs

Official Rust implementation of Apache Arrow
https://arrow.apache.org/
Apache License 2.0
2.62k stars 802 forks source link

object_store: Add enabled-by-default "fs" feature #6636

Open Turbo87 opened 3 weeks ago

Turbo87 commented 3 weeks ago

Which issue does this PR close?

Closes https://github.com/apache/arrow-rs/issues/6055.

Rationale for this change

see https://github.com/apache/arrow-rs/issues/6055 😉

What changes are included in this PR?

This PR introduces a new fs feature for the object_store crate, which is enabled by default. If disabled, the local module is excluded from the crate and the walkdir dependency is skipped.

Are there any user-facing changes?

Only for users of default-features = false, but since this crate did not have any default features before there probably won't be many object_store users that specify default-features = false.

Turbo87 commented 3 weeks ago

/cc @tustvold

tustvold commented 3 weeks ago

I had a quick look and this looks plausible, however, it is a breaking change and will therefore need to wait for the next major release