Closed austin362667 closed 2 weeks ago
Thanks @tustvold @alamb @findepi for the review.
i32
rather than u32
to make code consistent.from_unary
suggested from @findepi bit_length_null_utf8view
test cases suggested by @tustvold .Switching to from_unary has reverted the optimisation to not inspect the string data - https://github.com/apache/arrow-rs/pull/6671#discussion_r1827848438 is how to do this correctly
Got it! Thanks @tustvold I replaced from_unary
with the approach you suggested.
Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/13195
Rationale for this change
Thanks to @jayzhan211 , he noticed following issue, array compute kernel
bit_length()
doesn't supportUtf8View
type:caused the error:
What changes are included in this PR?
Update
bit_length()
array function to supportUtf8View
Are there any user-facing changes?