search

apache / arrow-rs

Official Rust implementation of Apache Arrow
https://arrow.apache.org/
Apache License 2.0
2.62k stars 802 forks source link

Minor: Document pattern for accessing views in StringView #6673

Closed alamb closed 2 weeks ago

alamb commented 2 weeks ago

Which issue does this PR close?

Closes #.

Rationale for this change

While reviewing https://github.com/apache/arrow-rs/pull/6671#pullrequestreview-2411229141 from @austin362667 I got nerdsniped trying to find documentation on how to work with the views of the StringView

What changes are included in this PR?

  1. Improve documentation for GenericByteViewArray
  2. Add example of how to work with u128 views

Are there any user-facing changes?

Better docs. No functional changes

alamb commented 2 weeks ago

LGTM, although I think the PartialEq situation is a bug that should be fixed

Tracked in https://github.com/apache/arrow-rs/issues/6679

alamb commented 2 weeks ago

Thank you for the reviews @austin362667 @tustvold and @jayzhan211