apache / arrow-rs

Official Rust implementation of Apache Arrow

https://arrow.apache.org/

Apache License 2.0

2.62k stars 802 forks source link

Expose 'parquet::record::make_row' function call to users #6762

Closed jonded94 closed 1 day ago

jonded94 commented 1 day ago

Which issue does this PR close?

Closes https://github.com/apache/arrow-rs/issues/6761

Rationale for this change

parquet::record::make_row was not exposed to users, leaving them no option to create parquet::record::Row objects themselfes.

What changes are included in this PR?

parquet::record::make_row is exposed publicy.

etseidl commented 1 day ago

If we want to allow creating Rows outside the module, would it be better to add a public new() to the Row API? (And maybe get rid of make_row?)

cc @alamb @tustvold

jonded94 commented 1 day ago

Implemented an alternative PR which does remove make_row entirely and creates a new method. https://github.com/apache/arrow-rs/pull/6763

Let me know whichever approach you prefer :) This unfortunately currently blocks a bit my work (I have some manual steps where I explicitly modify & create new Row instances and can't do that right now), so I'm happy to have quick progress here.