search

apache / arrow-rs

Official Rust implementation of Apache Arrow
https://arrow.apache.org/
Apache License 2.0
2.62k stars 802 forks source link

CI is failing on master: doc check with error: unexpected `cfg` condition value: `gil-refs` #6771

Closed alamb closed 18 hours ago

alamb commented 18 hours ago

Describe the bug For example - https://github.com/apache/arrow-rs/actions/runs/11954573062/job/33324973470

error: unexpected `cfg` condition value: `gil-refs`
  --> arrow/src/pyarrow.rs:79:1
   |
79 | import_exception!(pyarrow, ArrowException);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `arrow-csv`, `arrow-ipc`, `arrow-json`, `chrono-tz`, `csv`, `default`, `ffi`, `force_validate`, `ipc`, `ipc_compression`, `json`, `prettyprint`, `pyarrow`, `pyo3`, `rand`, and `test_utils`
   = help: consider adding `gil-refs` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: `-D unexpected-cfgs` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
   = note: this error originates in the macro `$crate::impl_exception_boilerplate` which comes from the expansion of the macro `import_exception` (in Nightly builds, run with -Z macro-backtrace for more info)

error: unexpected `cfg` condition value: `gil-refs`
  --> arrow/src/pyarrow.rs:79:1
   |
79 | import_exception!(pyarrow, ArrowException);
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `arrow-csv`, `arrow-ipc`, `arrow-json`, `chrono-tz`, `csv`, `default`, `ffi`, `force_validate`, `ipc`, `ipc_compression`, `json`, `prettyprint`, `pyarrow`, `pyo3`, `rand`, and `test_utils`
   = help: consider adding `gil-refs` as a feature in `Cargo.toml`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: this error originates in the macro `$crate::impl_exception_boilerplate` which comes from the expansion of the macro `import_exception` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not document `arrow`
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

To Reproduce

cargo update
rustup update
cargo doc --document-private-items --no-deps --workspace --all-features

Expected behavior CI should pass

Additional context

alamb commented 18 hours ago

This actually appears to have been fixed by

(thanks @psvri 🙏 )