search

apache / arrow-site

Mirror of Apache Arrow site
Apache License 2.0
31 stars 106 forks source link

[Website] Fix broken link #436

Closed llama90 closed 7 months ago

llama90 commented 7 months ago

According to the issue, it can be confirmed that the link to Community -> Contributing is broken on the main page of the Arrow website.

If the correct link would be to the Contributing Overview, it seems that it needs to be updated accordingly.

llama90 commented 7 months ago

Ah... I got it.

Thanks for the detailed explanation.

I'll close this PR.

AlenkaF commented 7 months ago

Oh yes, this should be fixed. But the correct link should point to: https://arrow.apache.org/docs/developers/index.html

@llama90 would you be able to make a PR on the main apache/arrow repo?

AlenkaF commented 7 months ago

Hm, I think this will in fact need a change in the arrow-site repo as already done in this PR. Only the link should be changed from <a class="dropdown-item" href="{{ site.baseurl }}/docs/developers/contributing.html">Contributing</a> to <a class="dropdown-item" href="{{ site.baseurl }}/docs/developers/index.html">Contributing</a>

llama90 commented 7 months ago

Hello @AlenkaF

Should I reopen the PR considering the feedback you provided?

AlenkaF commented 7 months ago

Yes please

llama90 commented 7 months ago

@AlenkaF OMG, I'm sorry.

Since I did a force push, I couldn't reopen the issue, so I created a new PR.

Sorry for the inconvenience.

AlenkaF commented 7 months ago

No problem 👍