search

apache / arrow-site

Mirror of Apache Arrow site
Apache License 2.0
33 stars 108 forks source link

[Website]: Update instructions with workaround for new ruby #448

Closed alamb closed 9 months ago

alamb commented 9 months ago

Update readme with a workaround described on https://github.com/apache/arrow-site/issues/447

Pinning the ruby version means the site builds for me now locally

alamb commented 9 months ago

@kou does this make sense to you?

kou commented 9 months ago

How about using the latest Jekyll instead?

diff --git a/Gemfile b/Gemfile
index cbffec8afe2..782ce6a652b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -18,7 +18,7 @@
 source "https://rubygems.org"
 ruby RUBY_VERSION

-gem "jekyll", "4.2.0"
+gem "jekyll", "4.3.3"
 gem "rake"
 gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]
 gem "webrick"

I already fixed this https://github.com/jekyll/jekyll/pull/9392 :-) and new version that includes this fix was released recently.

bkmgit commented 9 months ago

Maybe good to update all javascript dependencies as well. Have a draft at https://github.com/apache/arrow-site/pull/449 need to update lock files and check documentation builds if it would be considered.

alamb commented 9 months ago

How about using the latest Jekyll instead?

I will try this

alamb commented 9 months ago

How about using the latest Jekyll instead?

diff --git a/Gemfile b/Gemfile
index cbffec8afe2..782ce6a652b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -18,7 +18,7 @@
 source "https://rubygems.org"
 ruby RUBY_VERSION

-gem "jekyll", "4.2.0"
+gem "jekyll", "4.3.3"
 gem "rake"
 gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]
 gem "webrick"

I already fixed this jekyll/jekyll#9392 :-) and new version that includes this fix was released recently.

It worked -- made a new PR: https://github.com/apache/arrow-site/pull/451

alamb commented 8 months ago

Went with the new approach in https://github.com/apache/arrow-site/pull/451