search

apache / arrow

Apache Arrow is a multi-language toolbox for accelerated data interchange and in-memory processing
https://arrow.apache.org/
Apache License 2.0
13.87k stars 3.38k forks source link

[C++] example parquet-arrow project includes broken FindParquet.cmake #24247

Open asfimport opened 4 years ago

asfimport commented 4 years ago

The example project at https://github.com/apache/arrow/tree/master/cpp/examples/parquet/parquet-arrow/cmake_modules includes a broken version of FindParquet.cmake ( https://github.com/apache/arrow/blob/master/cpp/examples/parquet/parquet-arrow/cmake_modules/FindParquet.cmake )

The other module is, correctly, a link to FindArrow.cmake in https://github.com/apache/arrow/tree/master/cpp/cmake_modules

For the curious, the broken part is assuming that FindPkgConfig variables will be set if the module is found - this can be false if the include directory is /usr/include. This can be controlled by one of FindPkgConfig's config variables, but the default behaviour changes as of CMake 3.10. It then erroneously reports that Parquet has not been found.

This is not a major bug, but I based my build files off of those in the example directory and it took me a LONG time to figure out the error. It can be really confusing for new users and is simple to fix.

Environment: NA Reporter: Tomasz Cheda

Note: This issue was originally created as ARROW-8032. Please see the migration documentation for further details.

asfimport commented 1 year ago

Todd Farmer / @toddfarmer: This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.