search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.59k stars 3.54k forks source link

[GLib] GARROW_VERSION_0_16 macro is missing #27697

Closed asfimport closed 3 years ago

asfimport commented 3 years ago

GARROW_VERSION_0_16 macro is missing in arrow-glib/version.h. The absence of this macro occurs the warning like below:


compiling ../../../../ext/arrow-nmatrix/arrow-nmatrix.c
In file included from /opt/arrow-dbg/include/arrow-glib/arrow-glib.h:23,
                 from ../../../../ext/arrow-nmatrix/arrow-nmatrix.c:17:
/opt/arrow-dbg/include/arrow-glib/version.h:297:36: warning: "GARROW_VERSION_0_16" is not defined, evaluates to 0 [-Wundef]
  297 | #if GARROW_VERSION_MIN_REQUIRED >= GARROW_VERSION_0_16
      |                                    ^~~~~~~~~~~~~~~~~~~
/opt/arrow-dbg/include/arrow-glib/version.h:305:34: warning: "GARROW_VERSION_0_16" is not defined, evaluates to 0 [-Wundef]
  305 | #if GARROW_VERSION_MAX_ALLOWED < GARROW_VERSION_0_16
      |                                  ^~~~~~~~~~~~~~~~~~~

Reporter: Kenta Murata / @mrkn Assignee: Kenta Murata / @mrkn

PRs and other links:

Note: This issue was originally created as ARROW-11850. Please see the migration documentation for further details.

asfimport commented 3 years ago

Kenta Murata / @mrkn: Issue resolved by pull request 9623 https://github.com/apache/arrow/pull/9623