apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.48k stars 3.52k forks source link

[CI][C++][Python] Exercise builds on GCC 4.8 #29940

Closed asfimport closed 2 years ago

asfimport commented 3 years ago

Add a build to .github/workflows/cpp.yml with ARROW_PYTHON=ON to avoid issues like https://issues.apache.org/jira/browse/ARROW-14369

We may extend our docker-compose configuration to include CentOS 7/8 for testing C++ and Python.

cc @kou

Reporter: Krisztian Szucs / @kszucs

Note: This issue was originally created as ARROW-14372. Please see the migration documentation for further details.

asfimport commented 3 years ago

Neal Richardson / @nealrichardson: FWIW we test CentOS 7/gcc 4.8 with an R build, but that of course doesn't test all of the C++ features (notably here, ARROW_PYTHON). So we have limited coverage today.

asfimport commented 3 years ago

Kouhei Sutou / @kou: FYI: CentOS 8 will reach EOL soon: https://www.centos.org/centos-linux-eol/

We need to use AlmaLinux 8 instead.

asfimport commented 2 years ago

Raúl Cumplido / @raulcd: centos-cpp-static with centos 7/GCC 4.8 was added on: https://issues.apache.org/jira/browse/ARROW-16402

It does test C++ and R. I can't see it being triggered on our nightlies. @assignUser @nealrichardson  Do you know if it's being exercised/where? I might do some refactoring around it and add one for Python to close this ticket

asfimport commented 2 years ago

Neal Richardson / @nealrichardson: It's used in the r-binary-packages job. It builds the C++ library but does not run C++ tests.

However, given that we're requiring C++17 in ARROW-17545, gcc 4.8 will no longer be supported, so this issue is no longer relevant.

asfimport commented 2 years ago

Raúl Cumplido / @raulcd: I am closing this as Won't Do as discussed. It is not relevant any more if we require C++ 17. Feel free to r-open if I missed anything.

asfimport commented 2 years ago

Raúl Cumplido / @raulcd: As seen on the comments gcc 4.8 is won't be supported requiring C++17. The ticket is not relevant anymore.