search

apache / arrow

Apache Arrow is a multi-language toolbox for accelerated data interchange and in-memory processing
https://arrow.apache.org/
Apache License 2.0
13.96k stars 3.4k forks source link

[Python][Gandiva] Deprecate or hide make_projector and make_filter testing utilities #30517

Open asfimport opened 2 years ago

asfimport commented 2 years ago

pyarrow.gandiva.{make_filter, make_projector} functions are only used from gandiva unittests. Additionally unexpected arguments can cause segmentations faults. We either should deprecate or hide these functions from the public API.

Reporter: Krisztian Szucs / @kszucs

Note: This issue was originally created as ARROW-14996. Please see the migration documentation for further details.

asfimport commented 2 years ago

Will Jones / @wjones127: I thought these are an essential part of the API. The Filter and Projector classes both explicitly say to use these function to construct their respective objects.

https://github.com/apache/arrow/blob/d3bf0f6560dce414c8baea0c473b6f7eba1ef070/python/pyarrow/gandiva.pyx#L220

asfimport commented 2 years ago

Will Jones / @wjones127: The issue where unexpected arguments cause segfaults was what I was trying to address in ARROW-11341.