search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.53k stars 3.54k forks source link

[C++] Disable anonymous namespaces in debug mode #32663

Open asfimport opened 2 years ago

asfimport commented 2 years ago

I've had some pain points when using GDB and the pervasive use of anonymous namespaces throughout the code. I sent out an email on the mailing list and no one seemed to have any opinions, so I am opening this task. This task will gate anonymous namespaces around a #ifndef NDEBUG flag (or perhaps make a RELEASE_MODE_ANONYMOUS_NAMESPACE macro of some sort).

 

Mailing list discussion: https://lists.apache.org/thread/61rjzb18mvft7lpwglyh4kq2gkbog4ts

Reporter: Sasha Krassovsky / @save-buffer

Note: This issue was originally created as ARROW-17392. Please see the migration documentation for further details.

asfimport commented 2 years ago

Antoine Pitrou / @pitrou: I'm not sure about this, but if we do it we probably want to hide it behind macros to avoid littering the code with ifdef's.

@bkietz for opinions.

asfimport commented 1 year ago

Apache Arrow JIRA Bot: This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.