search

apache / arrow

Apache Arrow is a multi-language toolbox for accelerated data interchange and in-memory processing
https://arrow.apache.org/
Apache License 2.0
14.3k stars 3.48k forks source link

[Dev][Release] Verification script doesn't test amd64 architecture on arm64 mac #33818

Open kszucs opened 1 year ago

kszucs commented 1 year ago

Describe the bug, including details regarding any error messages, version, and platform.

TEST_DEFAULT=0 TEST_APT=1 TEST_YUM=1 dev/release/verify-release-candidate.sh <version> <rc> runs the APT/YUM tests in docker containers. Docker Desktop on mac uses arm64 images for both debian:bullseye and arm64v8/debian:bullseye images, but actually capable of running both architectures.

Changing the "arch-less" image names to amd64/ prefixed ones resolves the issue for me, so amd64/debian:bullseye instead of debian:bullseye. This should continue to work on amd64 hosts.

arm64 macs should be able to test all images on for both architectures.

Component(s)

Developer Tools, Release

kou commented 1 year ago

Or we may want to use --platform linux/amd64/--platform linux/amr64 docker run option.

kszucs commented 1 year ago

Yes, that should be the modern approach.