Closed jorisvandenbossche closed 2 weeks ago
:warning: GitHub issue #41688 has been automatically assigned in GitHub to PR creator.
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 14b8ca53171435113a0f0f0c4ff1063d12543bc4.
There was 1 benchmark result indicating a performance regression:
ursa-i9-9960x
at 2024-05-17 12:51:40Z
The full Conbench report has more details.
Rationale for this change
Some CMakeLists.txt files are not included in the pre-commit hook (causing failures on CI through archery if you rely on the pre-commit hook locally)
What changes are included in this PR?
Include all CMakeLists.txt files by default anywhere in the repo, and explicitly exclude the ones we don't want (vendored files).
In practice, compared to the current set of files covered by the hook, those new files are included in the search:
'cpp/CMakeLists.txt', 'java/CMakeLists.txt', 'matlab/CMakeLists.txt', 'python/CMakeLists.txt'
Are these changes tested?
Yes