search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.56k stars 3.54k forks source link

[C++] Rename the fixed-width concept from fixed_width_internal.h to "generalized fixed-width" #41963

Open felipecrv opened 5 months ago

felipecrv commented 5 months ago

Describe the enhancement requested

The concept was introduced in [1]. I initially called it "fixed modulo nesting", but renamed it to "fixed width" from review feedback. Conversation in [2] gives a good name suggestion to avoid the ambiguity: generalized fixed-width.

[1] https://github.com/apache/arrow/pull/41297 [2] https://github.com/apache/arrow/pull/41373#discussion_r1588599102

Component(s)

C++

pitrou commented 1 month ago

@felipecrv This should be an easy change, do you want to do it?

felipecrv commented 1 month ago

@felipecrv This should be an easy change, do you want to do it?

You can do it if you want. It might not be as straight forward as this new name is much longer.