[C++][Parquet] Add test function to compare underlying values of Arrow arrays, not including type

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics

https://arrow.apache.org/

Apache License 2.0

14.56k stars 3.54k forks source link

[C++][Parquet] Add test function to compare underlying values of Arrow arrays, not including type #42777

Open asfimport opened 6 years ago

asfimport commented 6 years ago

For unsigned integer typed Arrow arrays read in from parquet files we want to compare the values (which are stored as signed integers) but we don't want to fail an assertion because the types of the Arrow arrays are different.

Reporter: Phillip Cloud / @cpcloud Assignee: Phillip Cloud / @cpcloud

_{Note: This issue was originally created as PARQUET-1163. Please see the migration documentation for further details.}

asfimport commented 6 years ago

Wes McKinney / @wesm: Should this be an Arrow JIRA?

asfimport commented 6 years ago

Phillip Cloud / @cpcloud: It could be, though this particular issue came up because of the logical/physical type separation in parquet. I think in general we want to compare types when asserting that arrays are equal in tests, and leave the special case comparisons (like this one) as close to the location they are needed. However, if this is generally useful outside of parquet-cpp then I can move it to Arrow.