search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.6k stars 3.54k forks source link

[CI][Dev] Add shell script linter #43080

Closed kou closed 2 days ago

kou commented 4 months ago

Describe the enhancement requested

Candidate:

Component(s)

Continuous Integration, Developer Tools

pitrou commented 2 months ago

This sounds like a good idea to me. I'm very bad at writing shell scripts and I would appreciate this.

kou commented 2 months ago

I've introduced shellcheck and shfmt to apache/arrow-go by https://github.com/apache/arrow-go/commit/d486377db4f25b0c38a2a16715c6c7d6d36745b8#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9 . I'll do the same thing to apache/arrow after we completed the apache/arrow-go migration.

pitrou commented 4 days ago

I still think this would be a good idea. Also cc @assignUser

assignUser commented 4 days ago

Yeah bashls is screaming at me everytime I open one of our scripts xD

assignUser commented 2 days ago

Issue resolved by pull request 44724 https://github.com/apache/arrow/pull/44724

pitrou commented 2 days ago

Thanks, now I suppose we should go and fix all problematic scripts in the codebase?

kou commented 16 hours ago

Yes. Let's track it in #44748.