search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.5k stars 3.53k forks source link

[C++] Implement cast suggestions for all nested types in Concatenate #43316

Open felipecrv opened 3 months ago

felipecrv commented 3 months ago

Describe the enhancement requested

43190 improves error messages in case of offset overflow when string/binary/list arrays are being concatenated. These values can live inside nested types (e.g. struct), so when concatenating a type like struct<a: int8, b: list> an overflow on the recursive concatenation of field b should lead to a cast suggestion to struct<a: int8, b: large_list>.

Component(s)

C++

sunby commented 3 months ago

I would like to take a try.

sunby commented 3 months ago

take

felipecrv commented 3 months ago

@sunby don't try to fix them all before opening a PR for review. Take a look at how it was done for lists in he PR linked above.

sunby commented 3 months ago

@sunby don't try to fix them all before opening a PR for review. Take a look at how it was done for lists in he PR linked above.

thanks for the advice! I plan to split them into several PRs and start from the struct type.

laksh-krishna-sharma commented 3 months ago

May I work on this issue with a little bit of your guidance?