search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.52k stars 3.53k forks source link

[Archery][CI] Deprecate ARCHERY_USE_DOCKER_CLI option #43613

Open pitrou opened 2 months ago

pitrou commented 2 months ago

Describe the enhancement requested

The ARCHERY_USE_DOCKER_CLI originally avoids using the docker-compose utility and using the docker CLI directly instead. However, with #43608 now fixed, our usage of docker-compose has mostly been replaced with the docker compose subcommand which should fix the issues and shortcomings of docker-compose. Therefore, ARCHERY_USE_DOCKER_CLI may have become irrelevant.

@kou @kszucs Thoughts?

Component(s)

Archery, Continuous Integration

kou commented 2 months ago

+1

pitrou commented 2 months ago

Hmm, there's also a ARCHERY_USE_DOCKER_BUILDX option that allows building an image using docker buildx instead of docker build. I don't know how useful it is.

kszucs commented 2 months ago

At the time of the development docker's ecosystem across the various platforms was rather fragmented, some of the tools were better in caching (I mean they had proper cache hits) but not available on certain platform. We also used archery ok self hosted machines where these options were handy (compose for example didn't have cache hits on self hosted machines but plain docker had). I believe these differences are now gone, so I think both docker-compose and buildx related options and flags can be safely removed.

kou commented 2 months ago

Let's deprecated both of ARCHERY_USE_DOCKER_CLI and ARCHERY_USE_DOCKER_BUILDX.