search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.56k stars 3.54k forks source link

[C++][FS][Azure] Add support for azure-storage-blobs-cpp 12.12.0 #43702

Closed kou closed 2 months ago

kou commented 2 months ago

Describe the enhancement requested

Our bundled Azure SDK for C++ is azure-core_1.10.3 but conda uses more recent version:

https://github.com/ursacomputing/crossbow/actions/runs/10391631674/job/28774978364#step:7:933

azure-core-cpp            1.13.0               h935415a_0    conda-forge
azure-identity-cpp        1.9.0                hd126650_0    conda-forge
azure-storage-blobs-cpp   12.12.0              hd2e3451_0    conda-forge
azure-storage-common-cpp  12.7.0               h10ac4d7_1    conda-forge
azure-storage-files-datalake-cpp 12.11.0              h325d260_1    conda-forge

It causes test failures:

https://github.com/ursacomputing/crossbow/actions/runs/10391631674/job/28774978364#step:7:13273

C++ exception with description "400 The API version 2024-08-04 is not supported by Azurite. Please upgrade Azurite to latest version and retry. If you are using Azurite in Visual Studio, please check you have installed latest Visual Studio patch. Azurite command line parameter "--skipApiVersionCheck" or Visual Studio Code configuration "Skip Api Version Check" can skip this error.
The API version 2024-08-04 is not supported by Azurite. Please upgrade Azurite to latest version and retry. If you are using Azurite in Visual Studio, please check you have installed latest Visual Studio patch. Azurite command line parameter "--skipApiVersionCheck" or Visual Studio Code configuration "Skip Api Version Check" can skip this error.

Component(s)

C++

pitrou commented 2 months ago

Would it be enough to pass --skipApiVersionCheck? or does Azure really change its HTTP API every so often?

kou commented 2 months ago

Yes. --skipApiVersionCheck is enough.

In general, using the latest dependencies are good. So let's update our bundled Azure SDK for C++ too.

kou commented 2 months ago

Issue resolved by pull request 43723 https://github.com/apache/arrow/pull/43723