search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.63k stars 3.56k forks source link

MINOR: [Release] Proactively remove java-jni-dist directory in verification script #44718

Closed amoeba closed 1 week ago

amoeba commented 1 week ago

Rationale for this change

If you set ARROW_TMPDIR and run TEST_DEFAULT=0 TEST_INTEGRATION=1 dev/release/verify-release-candidate.sh repeatedly, you'll run into an error:

mv: rename /Users/bryce/src/apache/arrow/arrow-tempdir//java-jni-install/lib/arrow_cdata_jni to /Users/bryce/src/apache/arrow/arrow-tempdir//java-jni-dist/arrow_cdata_jni: Directory not empty

What changes are included in this PR?

In the test_package_java step in the verification script, I added a rm -frto get rid of java-jni-dist dir so the following mv command works.

Are these changes tested?

Yes, locally.

Are there any user-facing changes?

No.

amoeba commented 1 week ago

Reviewers feel free to suggest a safer alternative than rm -fr. I think it's safe here but happy to take feedback on it.

conbench-apache-arrow[bot] commented 1 week ago

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 354a22fa92b4a745adcc0f23bd89753f7af17f2f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.