Closed kou closed 5 days ago
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline
:warning: GitHub issue #27919 has been automatically assigned in GitHub to PR creator.
Revision: 5c7bb69461aa9606ce75630d5eb382020216bece
Submitted crossbow builds: ursacomputing/crossbow @ actions-08280626f5
Task | Status |
---|---|
test-ubuntu-24.04-cpp-bundled-offline |
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline
Revision: 62d877d4c3120305d79bdcfe3d6bf4dc46a76f63
Submitted crossbow builds: ursacomputing/crossbow @ actions-5c885d3fff
Task | Status |
---|---|
test-ubuntu-24.04-cpp-bundled-offline |
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline
Revision: 0dc30d9b8d1a9867450b7982bed60e02869d5b9b
Submitted crossbow builds: ursacomputing/crossbow @ actions-4c7b9cf02c
Task | Status |
---|---|
test-ubuntu-24.04-cpp-bundled-offline |
+1
I'll merge this.
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6427ed485221fad628d1c0b4a2a6e21450cb396e.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
Rationale for this change
If we have a nightly CI job to test offline build, we will be able to notice that offline build support is broken.
What changes are included in this PR?
ARROW_OFFLINE
option that usescpp/thirdparty/download_dependencies.sh
and disable DNS resolutionubuntu-cpp-bundled-offline
service that enable theARROW_OFFLINE
optiontest-ubuntu-24.04-cpp-bundled-offline
nightly jobAre these changes tested?
Yes.
Are there any user-facing changes?
No.