apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.65k stars 3.55k forks source link

GH-44223: [Dev] Use "Gandiva" instead of "C++ - Gandiva" label #44722

Closed kou closed 1 week ago

kou commented 1 week ago

Rationale for this change

We have Gandiva related codes. So "C++ -" isn't match the current code base.

What changes are included in this PR?

Remove the "C++ - " part.

Are these changes tested?

No.

Are there any user-facing changes?

No.

github-actions[bot] commented 1 week ago

:warning: GitHub issue #44223 has been automatically assigned in GitHub to PR creator.

kou commented 1 week ago

Ah, can we rename the existing "C++ - Gandiva" label to "Gandiva"?

raulcd commented 1 week ago

Ah, can we rename the existing "C++ - Gandiva" label to "Gandiva"?

Yes, I am going to rename the label and merge this.

raulcd commented 1 week ago

I've renamed the label: https://github.com/apache/arrow/labels/Component%3A%20Gandiva

kou commented 1 week ago

Thanks!

conbench-apache-arrow[bot] commented 1 week ago

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 26aa75f3b6a863ef62a22995843ae6314dfc261a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.